Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test cases. #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing test cases. #301

wants to merge 2 commits into from

Conversation

SeaSkyThe
Copy link

@SeaSkyThe SeaSkyThe commented Aug 3, 2024

Status

DEVELOPMENT

Description

I noticed that some tests were failing, so I'm working on fixing them by either adjusting the code behavior or modifying the tests. Out of 10 failing tests, I was able to fix 9 by making a minor adjustment to the SPLIT_RE regex.

Here’s what I’ve accomplished so far.

  • Handling strings with leading underscores for humps/main.py::_separate_words().
  • Adding new test case for tests/test_humps.py::test_camelized_acronyms().

Todos

  • Test case at tests/test_humps.py::26.

I'm unsure what the correct behavior should be for this. I would appreciate any help in understanding it better.
There is a related issue at #258 but it seems kinda ambiguous to me.

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

  • Just clone my fork and run the tests
git clone https://github.com/SeaSkyThe/humps
cd humps
git checkout master
pytest

Impacted Areas in Application

List general components of the application that this PR will affect:

  • Test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant